Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adoption of overflow toolbar - always stay in overflow area #4959

Open
1 task done
doruskova opened this issue Aug 10, 2023 · 1 comment
Open
1 task done

Adoption of overflow toolbar - always stay in overflow area #4959

doruskova opened this issue Aug 10, 2023 · 1 comment
Labels
feature-request New feature or request

Comments

@doruskova
Copy link

Is your feature request related to a problem?

During the object page implementation, we found out that we have to manually restrict the width of the toolbar because the React version doesn't support the option to choose items that always will be in the overflow area. If you create a button that looks like overflow and resize the screen, you'll get and overflow within the overflow and that's not ideal behavior. The situation becomes more difficult with access rights on these items because the width of the area dynamically changes.

Describe the solution you'd like

We would like to have a toolbar that allows you to select items that will always stay in the overflow area like here https://ui5.sap.com//#/entity/sap.m.OverflowToolbar/sample/sap.m.sample.OverflowToolbarSimple

Describe alternatives you've considered

We manually restricted the width of the toolbar area and we forced to show the overflow icon.

Additional Context

If there is any access rights applied, it's difficult to specify a fixed width of this area.

Declaration

  • I’m not disclosing any internal or sensitive information.
@doruskova doruskova added the feature-request New feature or request label Aug 10, 2023
@MarcusNotheis
Copy link
Contributor

Thanks for reaching out!
This issue is unfortunately quite complex to solve on our end due to the following reasons:

  1. As you already stated, our Toolbar component is currently not supporting the overflow priorities and adding this logic would result in massive changes in the component.
  2. The UI5 Web Components Team has already build a new Toolbar component (exposed as ToolbarV2 in Web Components for React) which is supporting the overflowPriority prop (not exposed in the docs yet), but unfortunately this new toolbar is only accepting a limited set of children (ToolbarButton, ToolbarSelect, ToolbarSeparator and ToolbarSpacer), so we can't use this new toolbar in our DynamicPage or ObjectPage yet.

We'll sync up with the UI5 Web Components Team on how we should proceed with the Toolbar (enhancing ours vs. supporting more children for Toolbar Web Component) - we'll keep you posted as soon as we know more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants