Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilterBar: missing accessibility properties for filterGroupItem #3573

Open
nidhi0104 opened this issue Sep 27, 2022 · 1 comment
Open

FilterBar: missing accessibility properties for filterGroupItem #3573

nidhi0104 opened this issue Sep 27, 2022 · 1 comment
Labels
a11y blocked bug Something isn't working

Comments

@nidhi0104
Copy link

Describe the bug
Screen renders don't read "required" for the fields that are enabled required.

Isolated Example
UI Link
Refer: https://sap.github.io/ui5-webcomponents-react/?path=/docs/layouts-floorplans-filterbar--default-story

To Reproduce
Steps to reproduce the behavior:

  1. Set property 'required' of filterGroupItem as true.
  2. Asterik(*) will come for the first filterGroupItem
  3. The screen render don't read out the 'required' word

Expected behavior
It should read out 'required' if some field is set as required

UI5 Web Components for React Information
@ui5/webcomponents version:1.6.0
@ui5/webcomponents-react version:0.27.5
Operating System:macOs
Browser:chrome

@nidhi0104 nidhi0104 added the bug Something isn't working label Sep 27, 2022
@Lukas742
Copy link
Contributor

Lukas742 commented Oct 6, 2022

Hi @nidhi0104

we're currently blocked to implement this on our end, as not all ui5 web components do yet support the required attribute. I've created issues regarding this in their repository (e.g. SAP/ui5-webcomponents#5895)
Until then you can just add required to the input you pass as child to the FilterGroupItem (if it's supported).

E.g.:

<FilterGroupItem required label="Filter 1">
  <Input required />
</FilterGroupItem>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y blocked bug Something isn't working
Projects
Status: Future
Development

No branches or pull requests

2 participants