Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target version 1.60.0 not found for api.json #89

Open
tobiasso85 opened this issue Jan 30, 2020 · 1 comment
Open

Target version 1.60.0 not found for api.json #89

tobiasso85 opened this issue Jan 30, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@tobiasso85
Copy link
Contributor

Problem

the parameter target-version is used to download the api information for resolving globals, e.g. sap.m.Label therefore the API version must match the one available on the https://sapui5.hana.ondemand.com/

ui5-migration analyze --target-version="1.60.0"
ui5-migration analyze --target-version="1.60.22"

produces different output

because

https://sapui5.hana.ondemand.com/1.60.22/ --> works
https://sapui5.hana.ondemand.com/1.60.0/ --> 404 Not Found

Proposal

throw an error and display it in the console.

1.60.0 was not officially released

E.g. could use:
https://sapui5.hana.ondemand.com/versionoverview.json

@tobiasso85 tobiasso85 changed the title Target version is used 1 to 1 to download api.json Target version 1.60.0 not found for api.json Jan 30, 2020
@tobiasso85 tobiasso85 self-assigned this Jun 22, 2020
@tobiasso85 tobiasso85 added the bug Something isn't working label Jun 22, 2020
@tobiasso85
Copy link
Contributor Author

Possible solution

An idea would be to create a method init in each task and this ensures all parameters are met to initiate the task.

For the ones which depend on the targetVersion it will then throw an error!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant