Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling sometimes breaks the source formatting #30

Open
codeworrior opened this issue Jul 15, 2019 · 0 comments
Open

Tooling sometimes breaks the source formatting #30

codeworrior opened this issue Jul 15, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@codeworrior
Copy link
Member

While working on SAP/openui5@c782ce9 , I encountered the following issue with the ui5-migration tooling:

The migration tooling sometimes breaks the source formatting, especially the indent of closing brackets. This might be a follow-up issue of #29, but I think I encountered it more often than #29.

Before

					...
					if (selectedItem == subItem) {
						popupSelectedItem = popupSubItem;
					}
				}

			}

			var newGroup = new NavigationListItem({
				expanded: true,
			...

After (note the curly braces which have moved, as has the follow-up statement)

					...
					if (selectedItem == subItem) {
						popupSelectedItem = popupSubItem;
				}

			}

			

		}

		var newGroup = new NavigationListItem({
				expanded: true,
		...

To reproduce, you can execute the following commands

cd openui5
git checkout 6555a38
ui5-migration migrate src/sap.tnt/src/sap/tnt/NavigationListItem.js
@ecker ecker added the enhancement New feature or request label Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants