Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI5 Migrate should return != 0, if files have been modified #209

Open
bkrrrr opened this issue Oct 22, 2021 · 0 comments
Open

UI5 Migrate should return != 0, if files have been modified #209

bkrrrr opened this issue Oct 22, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@bkrrrr
Copy link

bkrrrr commented Oct 22, 2021

This tool would be great to check UI5 apps in Github actions for none recommended code pattern.
The only thing missing, is a return code that lets a ci fail e.g. -1.

image

Workaround:

name: 'migration'
description: 'see https://www.npmjs.com/package/@ui5/migration'
runs:
  using: "composite"
  steps:
      - name: Install
        run: npm install --global @ui5/migration
        shell: bash
      # see https://github.com/SAP/ui5-migration/issues/209
      - name: run-migration 
        run: | 
          ui5-migration migrate
          echo 'delta<<EOF' >> $GITHUB_ENV
          git diff --color webapp/  >> $GITHUB_ENV
          echo 'EOF' >> $GITHUB_ENV
        shell: bash
      - name: check
        run: echo "${{ env.delta }}"  && exit ${{ env.delta && 1 || 0 }}
        shell: bash
@svbender svbender added the enhancement New feature or request label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants