Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the bootstrap mixin dependency #8498

Closed
mirkosoft opened this issue Aug 7, 2020 · 5 comments · Fixed by #9839
Closed

Remove the bootstrap mixin dependency #8498

mirkosoft opened this issue Aug 7, 2020 · 5 comments · Fixed by #9839
Assignees
@tobi-or-not-tobi
Labels
bug Something isn't working css !!!Deprecated => Use "styling" label instead team/praetorians
Projects
Spartacus Tribe Board
Milestone
3.0

Comments

@mirkosoft
Copy link
Contributor

mirkosoft commented Aug 7, 2020 •
edited

Since bootstrap 4.5.1 make-container-max-widths mixin is not present anymore which cause build error as spartacus make use of it. Let's check if we can remove it and remove if yes.

related to #8460
@mirkosoft mirkosoft added the bug Something isn't working label Aug 7, 2020
@mirkosoft mirkosoft added this to To Do in Spartacus Tribe Board via automation Aug 7, 2020
@mirkosoft
Copy link
Contributor Author

mirkosoft commented Aug 7, 2020 •
edited

However they've already brought it back and marked as deprecated:
twbs/bootstrap#31438
So if we can't remove the mixing we can revert the #8460 as 4.5.2 whould be the latest version (which shouldn't break the build).

@Xymmer Xymmer mentioned this issue Aug 11, 2020
Closed
@Xymmer
Copy link
Contributor

Xymmer commented Aug 11, 2020

Let's also check if #8444 is same issue as this one, and close other as dupe if so

@Xymmer
Copy link
Contributor

Xymmer commented Aug 12, 2020

We have ^ in our yarn but when installing bootstrap can update 4.x.x

@Xymmer
Copy link
Contributor

Xymmer commented Aug 12, 2020 •
edited

bug triage team agrees:

  • don't depend on this function as it's deprecated
  • unfreeze bootstrap after we don't depend on this function

can be done by miguel/mikel, but not urgent, setting to 3.x

@Xymmer Xymmer removed this from To Do in Spartacus Tribe Board Aug 12, 2020
@Xymmer Xymmer added this to the 3.x milestone Aug 12, 2020
@Xymmer Xymmer added css !!!Deprecated => Use "styling" label instead team/praetorians labels Aug 12, 2020
@Xymmer
Copy link
Contributor

Xymmer commented Aug 12, 2020

can be 3.x or sooner depending on capacity

@tobi-or-not-tobi tobi-or-not-tobi self-assigned this Nov 18, 2020
@tobi-or-not-tobi tobi-or-not-tobi mentioned this issue Nov 18, 2020
Merged
@tobi-or-not-tobi tobi-or-not-tobi modified the milestones: 3.x, 3.0-stretch Nov 18, 2020
@tobi-or-not-tobi tobi-or-not-tobi added this to To Do in Spartacus Tribe Board via automation Nov 18, 2020
@tobi-or-not-tobi tobi-or-not-tobi moved this from To Do to Code Review & Local QA in Spartacus Tribe Board Nov 18, 2020
tobi-or-not-tobi added a commit that referenced this issue Nov 18, 2020
@tobi-or-not-tobi
fix: drop unused and deprecated style rules (#9839)
5e96872 
fixes #8498
@tobi-or-not-tobi tobi-or-not-tobi moved this from Code Review & Local QA to Done in Spartacus Tribe Board Nov 24, 2020
@Xymmer Xymmer modified the milestones: 3.0-stretch, 3.0 Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobi-or-not-tobi tobi-or-not-tobi

Labels
bug Something isn't working css !!!Deprecated => Use "styling" label instead team/praetorians
Projects
No open projects
Spartacus Tribe Board
  
Done
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

fix: remove unused and deprecated styling SAP/spartacus
3 participants
@mirkosoft @tobi-or-not-tobi @Xymmer