Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning when building for production #2831

Closed
znikola opened this issue Jun 3, 2019 · 2 comments
Closed

Warning when building for production #2831

znikola opened this issue Jun 3, 2019 · 2 comments
Assignees
@reyhanehsalkhi
Labels
bug Something isn't working ng8
Projects
Gladiators SPRINT
Milestone
1.x

Comments

@znikola
Copy link
Contributor

znikola commented Jun 3, 2019

There a few warning when perform a production build:

'Observable' is imported from external module 'rxjs' but never used
'FormGroup' is imported from external module '@angular/forms' but never used

Screen Shot 2019-06-03 at 11 24 32

These are most likely coming from projects/storefrontlib/src/lib/checkout/components/payment-method/billing-address-form/billing-address-form.component.ts

We have two properties in the component:

  @Input()
  billingAddress: FormGroup;
  @Input()
  countries$: Observable<Country[]>;

In the generated dist/storefrontlib/esm2015/lib/checkout/components/payment-method/billing-address-form/billing-address-form.component.js file we end up with imports that are not used.
@znikola znikola added the ng8 label Jun 3, 2019
@Xymmer Xymmer added the bug Something isn't working label Jun 3, 2019
@Xymmer Xymmer added this to the 1.0 RC-0 milestone Jun 4, 2019
@Xymmer Xymmer added this to NEWLY ADDED - TO BE PRIORITIZED in Release 1.0 via automation Jun 4, 2019
@Xymmer Xymmer moved this from NEWLY ADDED - TO BE PRIORITIZED to RELEASE To Do in Release 1.0 Jun 10, 2019
@Xymmer Xymmer moved this from -- RELEASE To Do to HIGH-PRIORITY BUGS/TODO in Release 1.0 Jun 19, 2019
@bgambocjaviniar bgambocjaviniar moved this from HIGH-PRIORITY BUGS/TODO to In Progress in Release 1.0 Jun 21, 2019
@bgambocjaviniar bgambocjaviniar self-assigned this Jun 21, 2019
@Xymmer Xymmer modified the milestones: 1.0 RC-0, 1.0.1 Jun 25, 2019
@Xymmer Xymmer added this to To Do in Gladiators SPRINT via automation Jun 25, 2019
@Xymmer Xymmer removed this from In Progress in Release 1.0 Jun 25, 2019
@Xymmer Xymmer moved this from To Do to In Progress in Gladiators SPRINT Jun 25, 2019
@Xymmer Xymmer modified the milestones: 1.0.1, Right After 1.0 Jun 26, 2019
@bgambocjaviniar bgambocjaviniar moved this from In Progress to To Do in Gladiators SPRINT Jul 3, 2019
@Xymmer Xymmer removed this from To Do in Gladiators SPRINT Jul 29, 2019
@Xymmer Xymmer modified the milestones: 1.NEXT, 1.* Candidate Jul 30, 2019
@Xymmer Xymmer added the P3 label Nov 17, 2019
@LTiger14 LTiger14 assigned LTiger14 and reyhanehsalkhi and unassigned LTiger14 Dec 5, 2019
@LTiger14 LTiger14 added this to To Do in Gladiators SPRINT via automation Dec 6, 2019
@reyhanehsalkhi reyhanehsalkhi moved this from To Do to In Progress in Gladiators SPRINT Dec 9, 2019
@reyhanehsalkhi
Copy link
Contributor

It seems to be related to this bug in angular.

angular/angular#21280

@reyhanehsalkhi
Copy link
Contributor

The warnings are probably related to the known issue here angular/angular#21280 closing the issue.

@LTiger14 LTiger14 moved this from In Progress to Done in Gladiators SPRINT Dec 11, 2019
@Xymmer Xymmer modified the milestones: 2.x, 1.x Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reyhanehsalkhi reyhanehsalkhi

Labels
bug Something isn't working ng8
Projects
No open projects
Gladiators SPRINT
  
Done
Milestone
1.x
Development

No branches or pull requests
5 participants
@Xymmer @LTiger14 @znikola @bgambocjaviniar @reyhanehsalkhi