Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NITPICK] Keep server.ts template and server.ts in our storefrontapp as similar as fresh angular's created server.ts for consistency. #18236

Open
pawelfras opened this issue Dec 12, 2023 · 0 comments
Labels
ng17-upgrde Angular 17 upgrade issues

Comments

@pawelfras
Copy link
Contributor

          [NITPICK] Can be done in a separate PR/ticket as "further improvements" later:

For consistency, this server.ts template and server.ts in our storefrontapp, ideally, should be (nearly) the same as fresh angular's created server.ts.

So let's use:

import { fileURLToPath } from 'node:url';
import { dirname, join, resolve } from 'node:path';

and later on:

  const serverDistFolder = dirname(fileURLToPath(import.meta.url));
  const browserDistFolder = resolve(serverDistFolder, '../browser');
  const indexHtml = join(serverDistFolder, 'index.server.html');


...

Originally posted by @Platonn in #18228 (comment)

@pawelfras pawelfras added the ng17-upgrde Angular 17 upgrade issues label Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ng17-upgrde Angular 17 upgrade issues
Projects
None yet
Development

No branches or pull requests

1 participant