Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAJOR] Extract creating decorated engine to the separate function #18203

Open
pawelfras opened this issue Dec 5, 2023 · 0 comments
Open

[MAJOR] Extract creating decorated engine to the separate function #18203

pawelfras opened this issue Dec 5, 2023 · 0 comments
Labels
ng17-upgrde Angular 17 upgrade issues

Comments

@pawelfras
Copy link
Contributor

pawelfras commented Dec 5, 2023

          [MAJOR]

I guess we longer need the ngExpressEngine to be passed to some other function that decorates it, because now we control and create the ngExpressEngine. The decorator was meant to wrap the original Angular's ngExpressEngine that we don't create.

That said, removing it would be yet another migration to provide.

Example, but let's not do it now, only if we have more time:

import { createNgExpressEngine } from '@spartacus/setup/ssr;

const ngExpressEngine = createNgExpressEngine(ssrOptions);

Originally posted by @Platonn in #18197 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ng17-upgrde Angular 17 upgrade issues
Projects
None yet
Development

No branches or pull requests

1 participant