Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SearchBoxComponentService.getProductResults() public #18186

Open
filipe-esposito-kci opened this issue Nov 30, 2023 · 0 comments
Open

Make SearchBoxComponentService.getProductResults() public #18186

filipe-esposito-kci opened this issue Nov 30, 2023 · 0 comments

Comments

@filipe-esposito-kci
Copy link

Is your feature request related to a problem? Please describe.
getProductResults() is a useful method from the SearchBoxComponentService on our case, as we benefit from the fact that it returns the whole productResults object, because we need the keywordRedirectUrl field (whereas in the public method getResults(), which itself calls getProductResults(), returns only productResults.products). But this method is protected. We therefore had to create a custom service that extends SearchBoxComponentService, just to re-create getProductResults() ourselves, which simply calls super.getProductResults(config).

If .getProductResults() was a public method, we wouldn't need to do this.

Describe the solution you'd like
getProductResults() is changed from protected to public.

Additional context
Version 5.2 of Spartacus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant