Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes not being published #33

Closed
jbadan opened this issue Jun 7, 2019 · 2 comments
Closed

Release notes not being published #33

jbadan opened this issue Jun 7, 2019 · 2 comments
Labels
Good first issue Good for newcomers Help wanted Extra attention is needed

Comments

@jbadan
Copy link
Contributor

jbadan commented Jun 7, 2019

Release notes should look like the following: https://github.com/SAP/fundamental-react/releases/tag/v0.5.3

Screen Shot 2019-06-07 at 8 36 14 AM

This is being created by github-assistant, using the Changelog and github API, which require standard-version >=4.4.0. Unfortunately, we've had to lock on 4.2.0.

When attempting to upgrade any higher than 4.2.0, we encounter errors in Travis environment. Depending on the version, we get different variations of the same error:
Command failed: git commit --no-verify CHANGELOG.md -m "chore(release): version 0.1.0-rc.3 build 64 [ci skip]"
Not only is that failing, but it's skipping bumping the version in package.json and package-lock.json.

This does not happen on the other fundamental-* repos, using the exact same scripts, travis environment, standard-version version, etc.

See:
https://travis-ci.com/SAP/fundamental-styles/builds/114492798
https://travis-ci.com/SAP/fundamental-styles/builds/114465152

I believe it's related to these issues in standard-version, but I'm not sure how else to debug this as everything works locally, just not in Travis:
conventional-changelog/standard-version#256
conventional-changelog/standard-version#231

I think the root of the problem might be the changes made in 4.3.0 related to the skip argument: https://github.com/conventional-changelog/standard-version/blob/master/CHANGELOG.md#430-2018-01-03

@jbadan jbadan added the Help wanted Extra attention is needed label Jun 7, 2019
@droshev
Copy link
Contributor

droshev commented Oct 20, 2019

it happens to fundamental-ngx now

@stefanoScalzo stefanoScalzo added the Good first issue Good for newcomers label Nov 18, 2019
@jbadan
Copy link
Contributor Author

jbadan commented Apr 29, 2020

fixed by #864

@jbadan jbadan closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers Help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants