New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many Attribute Services #466

Open

davidlibrera opened this issue Jul 3, 2018 · 1 comment

Labels

enhancement informative resolved

Contributor

davidlibrera commented Jul 3, 2018 •

edited

I noticed that the current implementation of ruby-saml allow to insert into metadata just only one
<md:AttributeConsumingService />
https://github.com/onelogin/ruby-saml/blob/b0301c9da6c5c1674c29a8544c9e32d153bdbcca/lib/onelogin/ruby-saml/settings.rb#L28
while SAML specification for Metadata, at line 752 allow the presence of many attributes sets.

It could make sense to change this behaviour in order to enable ruby-saml gem to do this?

The text was updated successfully, but these errors were encountered:

Collaborator

pitbulk commented Jan 3, 2023

Is true that the spec allows to register more than 1 AttributeConsumingService.

But to simplify the settings, we implemented the ability to only register one service.

pitbulk added enhancement informative resolved labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment