Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubjectConfirmation validation not working #559

Open
GrahamCampbell opened this issue Jul 4, 2023 · 2 comments
Open

SubjectConfirmation validation not working #559

GrahamCampbell opened this issue Jul 4, 2023 · 2 comments

Comments

@GrahamCampbell
Copy link

GrahamCampbell commented Jul 4, 2023 •
edited

The following valid data is being rejected:

    <saml2:Subject>
      <saml2:NameID xmlns:saml2="urn:oasis:names:tc:SAML:2.0:assertion" Format="urn:oasis:names:tc:SAML:2.0:nameid-format:persistent" NameQualifier="https://samltest.id/saml/idp" SPNameQualifier="https://example.co/sso/saml2/223J5JXysUDoutRd1DHgmoYgVfk/metadata">KABUOZP2NMDOSU2L6ISHMEONVCFWVI2U</saml2:NameID>
      <saml2:SubjectConfirmation Method="urn:oasis:names:tc:SAML:2.0:cm:bearer">
        <saml2:SubjectConfirmationData Address="81.102.133.168" InResponseTo="ONELOGIN_f08011d1c9d5cf2479c06d773709f124433f3541" NotOnOrAfter="2023-07-04T09:21:26.053Z" Recipient="https://example.com/sso/saml2/223J5JXysUDoutRd1DHgmoYgVfk/acs"/>
      </saml2:SubjectConfirmation>
    </saml2:Subject>

The issue seems to be that the library code only works with saml and not saml2, which is also allowed by the spec.
@GrahamCampbell GrahamCampbell changed the title NotOnOrAfter and NotBefore validation is backwards SubjectConfirmation validation not working Jul 4, 2023
@GrahamCampbell
Copy link
Author

Seems to be an issue, even if saml2 is replaced with saml, actually.

@pitbulk
Copy link
Contributor

pitbulk commented Jul 20, 2023

@GrahamCampbell can you share what IdP are you using? What error do you get?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pitbulk @GrahamCampbell