Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting versions #550

Open
gweinfurther opened this issue Mar 9, 2023 · 1 comment
Open

Conflicting versions #550

gweinfurther opened this issue Mar 9, 2023 · 1 comment

Comments

@gweinfurther
Copy link

The files on the "Code" tab on the Github page are version 2.19.1, according to CHANGELOG. The class names do not use namespaces.

If I download the "master" package from Github, I get a file named php-saml-master.zip. This also contains version v.2.19.1 (according the CHANGELOG). The class names do not use namespaces. If I download using Git or Git Desktop, this is the file I get.

If I select the "Latest" button on the right side of the Github page, I get a file named php-saml-4.1.0.zip. It contains version v4.0.0 according to the CHANGELOG file. The class names use namespaces. There are no demo1, demo2, docs, endpoints, lib, or extlib folders included. This is also the version I get when I use composer.

This is very confusing and tripped me up when my code wouldn't work. Why does the Github page not include the correct version of the library? Why does the 4.1.0 package not include the demo1, demo2, docs, endpoints, lib, or extlib folders?

@pitbulk
Copy link
Contributor

pitbulk commented Mar 12, 2023

There are currently 3 active main branches:

  • master (2.X) php-5.4, PHP-7.0, PHP-7.1,PHP-7.1
  • 3.x-dev php-5.4, PHP-7.0, PHP-7.1,PHP-7.2, PHP-7.3, PHP-7.4
  • 4.x-dev PHP-7.3, PHP-7.4, PHP8.0, PHP8.1, PHP8.2

The download the "master" package from Github will provide you a zip with the master branch, an exact copy of the files available on GitHub.

The link of the release page point to the latest release done which is v4.1.0

Releases does not include demos, are intended to be directly used on production.
Similar behavior that if you install the extension via composer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants