Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent naming: encryption_algorithm should be encryptionAlgorithm #514

Open
recipe opened this issue Feb 14, 2022 · 1 comment
Open
Labels

Comments

@recipe
Copy link

recipe commented Feb 14, 2022

The encryption_algorithm option should be named as encryptionAlgorithm to be consistent.
7b4d4a6

Internally we keep onelogin/php-saml configuration with snake_case keys to be consistent with our own configuration naming conventions. Before creating the php-saml instance we transform all php-saml related keys to CamelCase and use this array to satisfy php-saml naming conventions. Now we will have to create a special rule for this single option to not to convert to CamelCase.

@pitbulk
Copy link
Contributor

pitbulk commented Dec 29, 2022

@recipe You are right, we should fix it by deprecating the use of encryption_algorithm (basically remove its use on demos and documentation) and in order to keep the backward compatibility read the possible values from encryption_algorithm and encryptionAlgorithm giving priority to the latest.

Can you contribute with a PR?

@pitbulk pitbulk added the Bug label Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants