Generating Metadata file - unused $attributes parameter

[programster]

I've just been getting started with using the package to try and generate my metadata file. I noticed that the builder static method takes a parameter called $attributes, which seems to be unused. Am I, or is the code missing something? Should the parameter just be removed?

Source file: https://github.com/onelogin/php-saml/blob/4.0.0/src/Saml2/Metadata.php

[pitbulk]

You are right, that parameter was introduced by error with this commit:
04285d6

But now we can't simpl remove it due compatiblity issues.

We should document in the code that this parameter is deprecated