Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make php-saml compatible with phpunit >= 7.5.18 #457

Open
pitbulk opened this issue Dec 28, 2020 · 0 comments
Open

Make php-saml compatible with phpunit >= 7.5.18 #457

pitbulk opened this issue Dec 28, 2020 · 0 comments

Comments

@pitbulk
Copy link
Contributor

pitbulk commented Dec 28, 2020

phpunit >= 7.5.18

This sebastianbergmann/phpunit#3968 introduces an incompatibility with php-saml test.

The redirectTo method has an exit which executed in a separated process now raises a

Test was run in child process and ended unexpectedly

I forced latest version of php-saml 3.X to use phpunit < 7.5.18
but we need to fix that in the future. The solutions:

  • Add stay=true to the redirectTo , login and logout methods.
  • Check on redirectTo method if a PHPUNIT_TEST constant is defined and if so, does not execute the exit and instead raise a controlled exception.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant