Skip to content
This repository has been archived by the owner on Dec 25, 2022. It is now read-only.

Internally developed update #17

Open
vpstuart opened this issue Oct 2, 2017 · 1 comment
Open

Internally developed update #17

vpstuart opened this issue Oct 2, 2017 · 1 comment

Comments

@vpstuart
Copy link

vpstuart commented Oct 2, 2017

Hi All,

I have been tasked with developing SAML integration for my company, and have used this project as a base. I have refactored it into a library and tried to make it a little general purpose without making it too complex.

Because its a decent refactor I didn't just want to put in a pull request. We would be willing to give back the full source code if there is any interest in publishing it attached to the onelogin name as MIT - as you guys did most of the work. Otherwise I guess I will just publish it as a new GitHub project??

Fixes include:

  • Added deflate compression, decompression as it wasn't working on Azure AD or ADFS without

Improvements:

  • Refactored as a DLL library
  • Add some functionality to pull out useful information from the response

To do:

  • I think the base implementation of signature checking is a bit naive and will probably explode if some of the other signing options are used.
  • Add a sample project

Cheers,

@pitbulk
Copy link
Contributor

pitbulk commented Oct 2, 2017

If you share the link I will try to review and provide feedback, and if I consider it mature I can add it to the list currently published on the README.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants