Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys.flags.int_max_str_digits is not -1 #5139

Open
youknowone opened this issue Dec 28, 2023 · 3 comments
Open

sys.flags.int_max_str_digits is not -1 #5139

youknowone opened this issue Dec 28, 2023 · 3 comments
Labels
C-bug Something isn't working

Comments

@youknowone
Copy link
Member

Summary

sys.flags.int_max_str_digits now returns sys.get_int_max_str_digits().

Introduced from https://github.com/RustPython/RustPython/pull/5127/files#diff-128fff16ea63b541718887f5c714e0c1a357414fe1146b4893ef699e8853e3b0R953

Related RustPython code is vm/src/stdlib.sys.rs Flags::int_max_str_digits.

Not sure yet if we need to change the value of Settings or sys::Flags.

@youknowone youknowone added the C-bug Something isn't working label Dec 28, 2023
@itsankitkp
Copy link
Contributor

Is this fixed now?
in rustpython (317f449)
sys.flags.int_max_str_digits returns -1
sys.get_int_max_str_digits() returns 4300
in cpython 3.11.6
same results as above.

Also, worked fine with -X int_max_str_digits flag

@fanninpm
Copy link
Contributor

fanninpm commented Jan 3, 2024

in cpython 3.11.6

Have you tried CPython 3.12?

@itsankitkp
Copy link
Contributor

in cpython 3.11.6

Have you tried CPython 3.12?

Tried latest cpython (3.13 dev version)
both sys.flags.int_max_str_digits and sys.get_int_max_str_digits() returns 4300
its coming from here: python/cpython#96499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants