Add cmovz/cmovnz support for aarch64. #744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes tests and I believe it works, but I also have the assembly programming experience of your average kindergartner, so a second opinion would be worth getting.
Running
cargo rustc --release -- --emit asm
on the portablecmovz
yields this:And a naive, branching version of
cmovz
yields this:Which makes me think
cmp
/csel
is the right choice.