Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpuid-bool: fix SGX support (take 2) #68

Merged
merged 1 commit into from Jul 14, 2020
Merged

cpuid-bool: fix SGX support (take 2) #68

merged 1 commit into from Jul 14, 2020

Conversation

newpavlov
Copy link
Member

Fixed version of #67

@newpavlov newpavlov merged commit d19e433 into master Jul 14, 2020
@newpavlov newpavlov deleted the sgx_fix2 branch July 14, 2020 12:44
@newpavlov newpavlov mentioned this pull request Aug 6, 2020
Closed
@tarcieri
Copy link
Member

tarcieri commented Aug 6, 2020

Does this mean all the feature flags will be false inside an SGX environment?

@newpavlov
Copy link
Member Author

Not quite, cpuid-bool takes into account target features enabled via compiler flags.

@tarcieri
Copy link
Member

tarcieri commented Aug 6, 2020

Aah... well then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@newpavlov @tarcieri