Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document #[zeroize(skip)] in the zeroize crate #662

Merged
merged 3 commits into from Nov 10, 2021

Conversation

daxpedda
Copy link
Contributor

@daxpedda daxpedda commented Nov 9, 2021

This actually documents the #[zeroize(skip)] functionality in the zeroize crate, until now it was only documented in the zeroize_derive crate.

Comment on lines 71 to 72
//! - `#[zeroize(drop)]`: call `zeroize()` when this item is dropped
//! - `#[zeroize(skip)]`: skips this field or variant when calling `zeroize()`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would probably be good to note that drop is a type-level attribute and skip is a field-level attribute

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I separated them into different lists, I think it would go quiet well with #663. WDYT?

@tarcieri
Copy link
Member

Looks good, thanks

@tarcieri tarcieri merged commit 3b81567 into RustCrypto:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants