Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hex-literal v0.3 #53

Merged
merged 8 commits into from Jul 16, 2020
Merged

hex-literal v0.3 #53

merged 8 commits into from Jul 16, 2020

Conversation

newpavlov
Copy link
Member

@newpavlov newpavlov commented Jun 1, 2020

This version will work only in Rust 1.45 and later.

Closes #25.

@@ -9,6 +9,5 @@ repository = "https://github.com/RustCrypto/utils"
keywords = ["hex", "proc-macro", "literals"]
edition = "2018"

[dependencies]
proc-macro-hack = "0.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray for proc_macro_hygiene! 😄

@newpavlov
Copy link
Member Author

newpavlov commented Jul 16, 2020

Hm, weird. CI runs for stable pass without issues, but 1.45.0 fails... In the log we can see:

info: installing component 'rustc'

  1.45.0-x86_64-unknown-linux-gnu installed - rustc 1.45.0 (5c1f21c3b 2020-07-13)

info: checking for self-updates
Gathering installed versions
  /usr/share/rust/.cargo/bin/rustc -V
  rustc 1.44.1 (c7087fe00 2020-06-17)
  /usr/share/rust/.cargo/bin/cargo -V
  cargo 1.44.1 (88ba85757 2020-06-11)
  /usr/share/rust/.cargo/bin/rustup -V
  rustup 1.22.1 (b01adbbc3 2020-07-08)

So if understand it correctly, Rust 1.45 didn't get installed for some reason, even though it should have.

@tarcieri
Copy link
Member

@newpavlov it's getting installed, however I think you need to add override: true here:

https://github.com/RustCrypto/utils/blob/master/.github/workflows/hex-literal.yml#L51

It looks like both of them start out with 1.44.1 as stable. When you upgrade stable it's working (because that's the default toolchain), but without override: true it's installing 1.45.0 but not using it because the default toolchain is still set to stable (which is still 1.44.1)

@newpavlov
Copy link
Member Author

Ah, indeed. We probably will need to check other repositories, since the config was based on a copy (although I don't remember from where).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on proc-macro-hack after proc_macro_expr stabilization
2 participants