Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add crates table to README #514

Merged
merged 3 commits into from Jul 2, 2021
Merged

Add crates table to README #514

merged 3 commits into from Jul 2, 2021

Conversation

newpavlov
Copy link
Member

@tarcieri Can you please check the crate descriptions (I had to shorten some of them a bit)?

@newpavlov newpavlov requested a review from tarcieri July 2, 2021 13:36
tarcieri
tarcieri approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The only thing I'd suggest is making use of a non-breaking hyphen in the crate names:

‑

@tarcieri
Copy link
Member

tarcieri commented Jul 2, 2021

@newpavlov something weird happening here:

Screen Shot 2021-07-02 at 4 17 27 PM

@newpavlov
Copy link
Member Author

Yeah, I've miscopied this part. :)

@tarcieri
Copy link
Member

tarcieri commented Jul 2, 2021

Looks good now!

@newpavlov newpavlov merged commit 5dbd867 into master Jul 2, 2021
@newpavlov newpavlov deleted the readme_table branch July 2, 2021 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@newpavlov @tarcieri