Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkcs8: decryption/encryption support for EncryptedPrivateKeyInfo #263

Closed
tarcieri opened this issue Feb 17, 2021 · 3 comments · Fixed by #293
Closed

pkcs8: decryption/encryption support for EncryptedPrivateKeyInfo #263

tarcieri opened this issue Feb 17, 2021 · 3 comments · Fixed by #293

Comments

@tarcieri
Copy link
Member

tarcieri commented Feb 17, 2021 •
edited

#262 added an initial pkcs8::EncryptedPrivateKeyInfo type with basic parsing/serialization support. However, it doesn't actually support decrypting/encrypting PrivateKeyInfo yet.

Ideally we should only support algorithms which are known to be secure. The most commonly supported ones are based on 56-bit DES, however those provide no effective security as 56-bit DES has far too small a keyspace to be secure against brute force attacks. However, there is support for modern algorithms like AES and old-but-still-secureish algorithms like 3DES in newer revisions of PKCS#5:

  • PKCS#5 v1.5 supports PBE-SHA1-3DES.
  • PKCS#5 v2 adds support for AES encryption with iterated PRFs such as hmacWithSHA256 (a.k.a. PBES2)

It would probably make sense to wait for the cipher crate v0.3 release before attempting to implement decryption/encryption support in pkcs8.
@tarcieri tarcieri mentioned this issue Feb 17, 2021
Closed
@tarcieri tarcieri changed the title pkcs8: decryption/encryption for EncryptedPrivateKeyInfo pkcs8: decryption/encryption support for EncryptedPrivateKeyInfo Feb 17, 2021
tarcieri added a commit that referenced this issue Feb 17, 2021
@tarcieri
pkcs8: add tracking issues for PKCS#8 encryption support
14fe253 
Updates the rustdoc with links to #263
@tarcieri tarcieri mentioned this issue Feb 17, 2021
Merged
tarcieri added a commit that referenced this issue Feb 17, 2021
@tarcieri
pkcs8: add tracking issues for PKCS#8 encryption support (#264)
f1a555d 
Updates the rustdoc with links to #263
tarcieri added a commit that referenced this issue Feb 17, 2021
@tarcieri
pkcs5: initial crate
4b7bbc4 
Adds an initial implementation of Public-Key Cryptography Standards
(PKCS) #5: Password-Based Cryptography Specification Version 2.1
as described in RFC 8018.

This implementation includes basic support for parsing
`AlgorithmIdentifier`s representing supported PKCS#5 algorithms into a
structured representation.

The larger goal is being able to decrypt/encrypt PKCS#8's
`EncryptedPrivateKeyInfo` (see #263)

This PR doesn't actually include any encryption support yet: instead it
implements the basic crate structure with the goal of adding encryption
support in follow-up PRs.

It also includes some changes to the `spki` crate to simplify parsing
which should probably be separated out into their own PR.
@tarcieri tarcieri mentioned this issue Feb 17, 2021
Merged
tarcieri added a commit that referenced this issue Feb 17, 2021
@tarcieri
pkcs5: initial crate
64f55c6 
Adds an initial implementation of Public-Key Cryptography Standards
(PKCS) #5: Password-Based Cryptography Specification Version 2.1
as described in RFC 8018.

This implementation includes basic support for parsing
`AlgorithmIdentifier`s representing supported PKCS#5 algorithms into a
structured representation.

The larger goal is being able to decrypt/encrypt PKCS#8's
`EncryptedPrivateKeyInfo` (see #263)

This PR doesn't actually include any encryption support yet: instead it
implements the basic crate structure with the goal of adding encryption
support in follow-up PRs.

It also includes some changes to the `spki` crate to simplify parsing
which should probably be separated out into their own PR.
@tarcieri
Copy link
Member Author

It seems like the first step towards getting this to work is implementing at least a subset of PKCS#5 (password-based encryption), which I've done in #272.

tarcieri added a commit that referenced this issue Feb 17, 2021
@tarcieri
pkcs5: initial crate
6237d05 
Adds an initial implementation of Public-Key Cryptography Standards
(PKCS) #5: Password-Based Cryptography Specification Version 2.1
as described in RFC 8018.

This implementation includes basic support for parsing
`AlgorithmIdentifier`s representing supported PKCS#5 algorithms into a
structured representation.

The larger goal is being able to decrypt/encrypt PKCS#8's
`EncryptedPrivateKeyInfo` (see #263)

This PR doesn't actually include any encryption support yet: instead it
implements the basic crate structure with the goal of adding encryption
support in follow-up PRs.

It also includes some changes to the `spki` crate to simplify parsing
which should probably be separated out into their own PR.
tarcieri added a commit that referenced this issue Feb 17, 2021
@tarcieri
pkcs5: initial crate
094765c 
Adds an initial implementation of Public-Key Cryptography Standards
(PKCS) #5: Password-Based Cryptography Specification Version 2.1
as described in RFC 8018.

This implementation includes basic support for parsing
`AlgorithmIdentifier`s representing supported PKCS#5 algorithms into a
structured representation.

The larger goal is being able to decrypt/encrypt PKCS#8's
`EncryptedPrivateKeyInfo` (see #263)

This PR doesn't actually include any encryption support yet: instead it
implements the basic crate structure with the goal of adding encryption
support in follow-up PRs.

It also includes some changes to the `spki` crate to simplify parsing
which should probably be separated out into their own PR.
tarcieri added a commit that referenced this issue Feb 18, 2021
@tarcieri
pkcs5: initial crate
b0f19fe 
Adds an initial implementation of Public-Key Cryptography Standards
(PKCS) #5: Password-Based Cryptography Specification Version 2.1
as described in RFC 8018.

This implementation includes basic support for parsing
`AlgorithmIdentifier`s representing supported PKCS#5 algorithms into a
structured representation.

The larger goal is being able to decrypt/encrypt PKCS#8's
`EncryptedPrivateKeyInfo` (see #263)

This PR doesn't actually include any encryption support yet: instead it
implements the basic crate structure with the goal of adding encryption
support in follow-up PRs.

It also includes some changes to the `spki` crate to simplify parsing
which should probably be separated out into their own PR.
tarcieri added a commit that referenced this issue Feb 18, 2021
@tarcieri
pkcs5: initial crate
9c37709 
Adds an initial implementation of Public-Key Cryptography Standards
(PKCS) #5: Password-Based Cryptography Specification Version 2.1
as described in RFC 8018.

This implementation includes basic support for parsing
`AlgorithmIdentifier`s representing supported PKCS#5 algorithms into a
structured representation.

The larger goal is being able to decrypt/encrypt PKCS#8's
`EncryptedPrivateKeyInfo` (see #263)

This PR doesn't actually include any encryption support yet: instead it
implements the basic crate structure with the goal of adding encryption
support in follow-up PRs.

It also includes some changes to the `spki` crate to simplify parsing
which should probably be separated out into their own PR.
tarcieri added a commit that referenced this issue Feb 18, 2021
@tarcieri
pkcs5: initial crate (#272)
bd26d68 
Adds an initial implementation of Public-Key Cryptography Standards
(PKCS) #5: Password-Based Cryptography Specification Version 2.1
as described in RFC 8018.

This implementation includes basic support for parsing
`AlgorithmIdentifier`s representing supported PKCS#5 algorithms into a
structured representation.

The larger goal is being able to decrypt/encrypt PKCS#8's
`EncryptedPrivateKeyInfo` (see #263)

This PR doesn't actually include any encryption support yet: instead it
implements the basic crate structure with the goal of adding encryption
support in follow-up PRs.
@tarcieri tarcieri mentioned this issue Feb 21, 2021
Merged
@tarcieri
Copy link
Member Author

This PR adds support for PKCS5 decryption: #293

@tarcieri
Copy link
Member Author

Encryption is support is released in v0.5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pkcs5 encryption + pkcs8 decryption RustCrypto/utils
1 participant
@tarcieri