elliptic-curve: add ReduceNonZero trait
#827
Merged
+37
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
elliptic-curve/reduce-non-zero
branch
from
be73184 to
fbb167c
Compare
Adds a trait similar to `Reduce`, but where the output of the reduction is ensured to be non-zero. Also impls `Reduce` and `ReduceNonZero` for `NonZeroScalar`. This means that end users need only concern themselves with `Reduce` as they can use `NonZeroScalar::<C>::from_uint_reduced` instead of the more cumbersome `Scalar::<C>::from_uint_reduced_non_zero`. Related: RustCrypto/elliptic-curves#432
tarcieri
force-pushed
the
elliptic-curve/reduce-non-zero
branch
from
fbb167c to
83874f3
Compare
tarcieri
added a commit
that referenced
this pull request
Dec 3, 2021
In #827, a `ReduceNonZero` trait was added whose method name uses an underscored `*_non_zero`. However, there's already one bit of precedent in the public API: - `SecretKey::to_nonzero_scalar` Since this is already a stable API and providing precedent, for consistency this commit changes all of the unstable/unreleased APIs and internal module naming to use `nonzero` instead of `non_zero`, as this is a non-breaking change.
tarcieri
added a commit
that referenced
this pull request
Dec 3, 2021
In #827, a `ReduceNonZero` trait was added whose method name uses an underscored `*_non_zero`. However, there's already one bit of precedent in the public API: - `SecretKey::to_nonzero_scalar` Since this is already a stable API and providing precedent, for consistency this commit changes all of the unstable/unreleased APIs and internal module naming to use `nonzero` instead of `non_zero`, as this is a non-breaking change.
This was referenced Dec 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a trait similar to
Reduce, but where the output of the reduction is ensured to be non-zero.Also impls
ReduceandReduceNonZeroforNonZeroScalar. This means that end users need only concern themselves withReduceas they can useNonZeroScalar::<C>::from_uint_reducedinstead of the more cumbersomeScalar::<C>::from_uint_reduced_non_zero.Related: RustCrypto/elliptic-curves#432
cc @fjarri