stream-cipher: add FromBlockCipherMut trait #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for initializing a stream cipher from a `BlockCipherMut`. This is a corollary to `FromBlockCipher`, but for cases where `mut` access is needed to the inner block cipher instance (e.g. cryptographic accelerator hardware peripherals). Using chained blanket impls, it's possible to allow a blanket impl of `NewStreamCipher` for types which impl either `FromBlockCipherMut` or `FromBlockCipher`.
|
Want to try this out with @newpavlov will make sure to get your review/approval before cutting a (non-pre)release with this change. We can always revert it. |
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
Expands the set of clippy lints applied to include ones intended to eliminate panics. Replaces `usize::try_from(n: u32).unwrap()` usages with `as u32` to avoid panics, avoiding possible truncation by adding a `compile_error!` if the `target_pointer_width` isn't 32 or 64-bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for initializing a stream cipher from a
BlockCipherMut.This is a corollary to
FromBlockCipher, but for cases where&mutaccess is needed to the inner block cipher instance (e.g. cryptographic accelerator hardware peripherals).Using chained blanket impls, it's possible to allow a blanket impl of
NewStreamCipherfor types which impl eitherFromBlockCipherMutorFromBlockCipher.