stream-cipher: remove NewBlockCipher bound on FromBlockCipher #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@newpavlov I'd like to merge this for now as it's badly blocking RustCrypto/stream-ciphers#170 and more specifically migrating Will wait for your input before cutting another release, though. Worst case we can revert it. |
Note: breaking change. As far as I can tell this was an oversight: `FromBlockCipher` never needs to instantiate a new block cipher (isn't that the point?), making this bound needlessly limiting. The rationale for it in the first place appears to be for the blanket impl of `NewStreamCipher` for `C: FromBlockCipher` which needs it, but we can add the bound to the blanket impl, rather than (needlessly) sticking it on the trait.
tarcieri
force-pushed
the
stream-cipher/remove-new-bound-on-from-block-cipher
branch
from
7c7a0db
to
b24065e
Compare
tarcieri
deleted the
stream-cipher/remove-new-bound-on-from-block-cipher
branch
This was referenced Oct 14, 2020
|
Looks good! I think it was indeed an oversight on my part. |
dns2utf8
pushed a commit
to dns2utf8/traits
that referenced
this pull request
Jan 24, 2023
- Bump version to `0.5.0-pre` (RustCrypto#247 contained breaking changes) - Use pointer casts to convert `Block` integer array to byte array - Rename `permutate!` to `permute!` (former isn't in OED, latter is)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: breaking change.
As far as I can tell this was an oversight:
FromBlockCiphernever needs to instantiate a new block cipher (isn't that the point?), making this bound needlessly limiting.The rationale for it in the first place appears to be for the blanket impl of
NewStreamCipherforC: FromBlockCipherwhich needs it, but we can add the bound to the blanket impl, rather than (needlessly) sticking it on the trait.