Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV on digest v0.10.4 is broken #1116

Closed
striezel opened this issue Sep 16, 2022 · 4 comments
Closed

MSRV on digest v0.10.4 is broken #1116

striezel opened this issue Sep 16, 2022 · 4 comments

Comments

@striezel
Copy link
Contributor

When trying to build a project that depends on digest v0.10.4 with rustc 1.48, one gets error messages from cargo. This appears to be a similar issue like e. g. RustCrypto/hashes#398 and probably needs a similar fix like RustCrypto/hashes#401.

The error message is:

error: failed to parse manifest at `/root/.cargo/registry/src/github.com-1ecc6299db9ec823/digest-0.10.4/Cargo.toml`

Caused by:
  feature `resolver` is required

  this Cargo does not support nightly features, but if you
  switch to nightly channel you can add
  `cargo-features = ["resolver"]` to enable this feature

The problem is due to the generated Cargo.toml containing the resolver = "2" line: https://docs.rs/crate/digest/0.10.4/source/Cargo.toml

Since the documented MSRV of digest is still rustc 1.41, this breaks the MSRV guarantee.

@newpavlov
Copy link
Member

newpavlov commented Sep 16, 2022

Argh... This error again. I will do release fix right away. Thank you for monitoring it!

@striezel
Copy link
Contributor Author

Thank you for monitoring it!

I am not actively monitoring it - even if it may look like it so soon after the release. I just happened to update the dependencies of one of my projects ca. 30 minutes ago, and that's where I hit that error.

@newpavlov
Copy link
Member

digest v0.10.5 is published. Can you verify that it fixes the issue?

@striezel
Copy link
Contributor Author

Yes, digest v0.10.5 can be compiled with rustc 1.48. So I consider this to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants