universal-hash: add back finalize_reset
#1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method was used by the `aes-gcm-siv` crate to handle a case where consuming `self` is problematic and borrowing `&mut self` is much more straightforward. It seems we've had several cases like this pop up with similar methods that were removed in other crates like `block-modes` and `digest`. The method is provided but bounded on `Clone + Reset`, with the latter sourced from `crypto-common`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was used by the
aes-gcm-sivcrate to handle a case where consumingselfis problematic and borrowing&mut selfis much more straightforward. It seems we've had several cases like this pop up with similar methods that were removed in other crates likeblock-modesanddigest.The method is provided but bounded on
Clone + Reset, with the latter sourced fromcrypto-common.