elliptic-curve: fix outdated doc #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `zeroize` feature flag has been removed, zeroization on drop is now done by default.
tarcieri
reviewed
Jul 16, 2022
Comment on lines
-6
to
-8
| //! | ||
| //! When the `zeroize` feature of this crate is enabled, it also handles | ||
| //! zeroing it out of memory securely on drop. |
There was a problem hiding this comment.
Perhaps this should still mention the secret is zeroed out of memory, but unconditionally?
There was a problem hiding this comment.
Good point, I've added that back now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zeroizefeature flag has been removed, zeroization on drop is now done by default.