Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affine y-coordinate access #1019

Open
nickray opened this issue Jun 2, 2022 · 3 comments
Open

Affine y-coordinate access #1019

nickray opened this issue Jun 2, 2022 · 3 comments

Comments

@nickray
Copy link
Member

nickray commented Jun 2, 2022

Understanding the arguments pro/con coordinates from #817...

For a generic-ish Frost implementation, I have need to determine if the output of distributed keygen has even y-coordinate, to perform the Taproot adjustment. I can get away with a local AffineYCoordinateParity trait (fn has_even_y(&self) -> bool) that I implement on k256 and bound on, but maybe "for symmetry" it wouldn't be that horrible to add either AffineYCoordinate or at least AffineYCoordinateParity to the AffineArithmetic::AffinePoint bounds?

@tarcieri
Copy link
Member

tarcieri commented Jun 2, 2022

See this PR for some additional context: RustCrypto/elliptic-curves#50

@tarcieri
Copy link
Member

tarcieri commented Jul 5, 2022

Some discussion of solving this in the group crate: zkcrypto/group#30

@tarcieri
Copy link
Member

#1237 has the best description of the current state of affairs and the evolution of these traits

@tarcieri tarcieri changed the title Add AffineYCoordinate trait? Affine y-coordinate access May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@tarcieri @newpavlov @nickray and others