Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove circular dependencies on aes crate #237

Closed
tarcieri opened this issue May 3, 2021 · 1 comment · Fixed by #276
Closed

Remove circular dependencies on aes crate #237

tarcieri opened this issue May 3, 2021 · 1 comment · Fixed by #276

Comments

@tarcieri
Copy link
Member

tarcieri commented May 3, 2021

Several crates in this repo use the aes crate as a dev-dependency.

The aes crate lists ctr in its (hard) dependencies section now.

This means that upgrading the cipher crate right now involves at least a temporary breakage. Here are some example PRs where this has happened:

#224 #225 #226 #227

There are at least two different ways this could be addressed, I think:

  1. Migrate the SIMD CTR implementation from the aes crate into the ctr crate, since it's not ctr-specific
  2. Use a different "example" block cipher as a dev-dependency
@newpavlov
Copy link
Member

I think a better approach would be to move all block mode crates to the block ciphers repository, as attempted in the RustCrypto/block-ciphers#233.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants