From d460daca04ee577a1fd7f3b6287efc0238fbd6b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=90=D1=80=D1=82=D1=91=D0=BC=20=D0=9F=D0=B0=D0=B2=D0=BB?= =?UTF-8?q?=D0=BE=D0=B2?= Date: Wed, 13 Jan 2021 23:36:33 +0300 Subject: [PATCH 1/2] Remove asm-related TODO comments --- sha1/src/compress.rs | 1 - sha2/src/sha256.rs | 1 - sha2/src/sha512.rs | 1 - 3 files changed, 3 deletions(-) diff --git a/sha1/src/compress.rs b/sha1/src/compress.rs index af35679b..c849c89e 100644 --- a/sha1/src/compress.rs +++ b/sha1/src/compress.rs @@ -10,7 +10,6 @@ cfg_if::cfg_if! { mod aarch64; use aarch64::compress as compress_inner; } else if #[cfg(all(feature = "asm", any(target_arch = "x86", target_arch = "x86_64")))] { - // TODO: replace after sha1-asm rework fn compress_inner(state: &mut [u32; 5], blocks: &[[u8; 64]]) { for block in blocks { sha1_asm::compress(state, block); diff --git a/sha2/src/sha256.rs b/sha2/src/sha256.rs index 8dade9f8..3eef7458 100644 --- a/sha2/src/sha256.rs +++ b/sha2/src/sha256.rs @@ -147,7 +147,6 @@ cfg_if::cfg_if! { mod aarch64; use aarch64::compress; } else if #[cfg(all(feature = "asm", any(target_arch = "x86", target_arch = "x86_64")))] { - // TODO: replace after sha2-asm rework fn compress(state: &mut [u32; 8], blocks: &[[u8; 64]]) { for block in blocks { sha2_asm::compress256(state, block); diff --git a/sha2/src/sha512.rs b/sha2/src/sha512.rs index 3280c6d2..55ca80da 100644 --- a/sha2/src/sha512.rs +++ b/sha2/src/sha512.rs @@ -232,7 +232,6 @@ cfg_if::cfg_if! { mod soft; use soft::compress; } else if #[cfg(all(feature = "asm", any(target_arch = "x86", target_arch = "x86_64")))] { - // TODO: replace after sha2-asm rework fn compress(state: &mut [u64; 8], blocks: &[[u8; 128]]) { for block in blocks { sha2_asm::compress512(state, block); From 646ef9a1b1b8ccfa9233be648955f47e1c52da89 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=90=D1=80=D1=82=D1=91=D0=BC=20=D0=9F=D0=B0=D0=B2=D0=BB?= =?UTF-8?q?=D0=BE=D0=B2?= Date: Wed, 13 Jan 2021 23:39:33 +0300 Subject: [PATCH 2/2] remove the last comment --- sha2/src/sha256/aarch64.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/sha2/src/sha256/aarch64.rs b/sha2/src/sha256/aarch64.rs index 1b8b0c8b..47796cf8 100644 --- a/sha2/src/sha256/aarch64.rs +++ b/sha2/src/sha256/aarch64.rs @@ -10,7 +10,6 @@ pub fn compress(state: &mut [u32; 8], blocks: &[[u8; 64]]) { // TODO: Replace with https://github.com/rust-lang/rfcs/pull/2725 // after stabilization if sha2_supported() { - // TODO: replace after sha2-asm rework for block in blocks { sha2_asm::compress256(state, block); }