New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small code improvements #94
Conversation
streebog/src/streebog.rs
Outdated
use digest::{Input, BlockInput, FixedOutput, Reset}; | ||
use digest::generic_array::typenum::{Unsigned, U64}; | ||
use digest::generic_array::typenum::U64; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build fails because you've removed Unsigned
here, I am not sure why it happens, but until we bump MSRV lets keep it as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right.
I've fixed it.
@newpavlov at first I was making a change but some time after I realized that it wasn't necessary. |
@newpavlov do you still intend to review it? |
Thanks! |
The build is failing due to a problem on
streebog.rs:149
but I haven't changed that.