Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sha2 fails to build in Windows on an ARM device #502

Closed
jdjaustin opened this issue Sep 19, 2023 · 2 comments
Closed

sha2 fails to build in Windows on an ARM device #502

jdjaustin opened this issue Sep 19, 2023 · 2 comments

Comments

@jdjaustin
Copy link

sha2 fails to build in Windows on an ARM device. Removing asm = ["sha2-asm"] from sha2/Cargo.toml allows the crate to build.
@tarcieri
Copy link
Member

The asm feature is unsupported on MSVC, which is my guess as to what is happening: RustCrypto/asm-hashes#17

We need to migrate to inline ASM, which will fix all of these platform-specific concerns.

@jdjaustin jdjaustin mentioned this issue Sep 19, 2023
Open
@newpavlov
Copy link
Member

You should find which crate in your dependency tree enables the asm feature. We explicitly state that this feature SHOULD NOT be enabled by library crates. The lack of Windows support is a known problem and tracked in the linked asm-hashes issue, so I think we can close this issue in favor of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tarcieri @newpavlov @jdjaustin