blake2: add Cargo feature to optimize for code size. #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
reviewed
Dec 16, 2022
blake2/Cargo.toml
Outdated
| @@ -25,3 +25,4 @@ reset = [] # Enable reset functionality | |||
| simd = [] | |||
| simd_opt = ["simd"] | |||
| simd_asm = ["simd_opt"] | |||
| size_opt = [] # Optimize for code size. Removes some `inline(always)` | |||
There was a problem hiding this comment.
Could you add a new line here?
Dirbaio
force-pushed
the
blake2-size-opt
branch
from
d1614be
to
b8907d6
Compare
|
Thank you! I will release it shortly. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation uses some
inline(always)to force inline theroundandquarter_roundfunctions for performance. This PR adds an opt-in Cargo feature to disable them, to allow optimizing for size instead.Building for
thumbv6m-none-eabi:size_optdisabled: 5772 bytessize_optenabled: 2372 bytesThis saves 3.4kb of code size, which is 60%.
I'm trying to use blake2 on a microcontroller with 32kb of Flash memory (where the code is stored), so saving 3.4kb is quite substantial.