Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV on whirlpool v0.10.2 and v0.10.3 is broken #397

Closed
striezel opened this issue Sep 2, 2022 · 2 comments · Fixed by #399
Closed

MSRV on whirlpool v0.10.2 and v0.10.3 is broken #397

striezel opened this issue Sep 2, 2022 · 2 comments · Fixed by #399

Comments

@striezel
Copy link
Contributor

striezel commented Sep 2, 2022

When trying to build a project that depends on whirlpool v0.10.2 with rustc 1.48, one gets error messages from cargo. This appears to be an instance of rust-lang/cargo#10954, which means the whirlpool crate simply needs to be re-uploaded with stable cargo or a newer nightly cargo.

The error message is:

error: failed to download `whirlpool v0.10.2`

Caused by:
  unable to get packages from source

Caused by:
  failed to parse manifest at `/root/.cargo/registry/src/github.com-1ecc6299db9ec823/whirlpool-0.10.2/Cargo.toml`

Caused by:
  feature `resolver` is required

  this Cargo does not support nightly features, but if you
  switch to nightly channel you can add
  `cargo-features = ["resolver"]` to enable this feature
@striezel
Copy link
Contributor Author

striezel commented Sep 2, 2022

@newpavlov: Thanks for the attempted fix in #399. 👍

Unfortunately, this issue is not fixed in whirlpool v0.10.3, the new release still contains a resolver = "2" line in the generated Cargo.toml: https://docs.rs/crate/whirlpool/0.10.3/source/Cargo.toml
Error message is basically still the same as shown above, except with a newer version number.

@striezel striezel changed the title MSRV on whirlpool v0.10.2 is broken MSRV on whirlpool v0.10.2 and v0.10.3 is broken Sep 2, 2022
@striezel
Copy link
Contributor Author

striezel commented Sep 2, 2022

The issues seems to be fixed by #401, i. e. in whirlpool v0.10.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant