Reduce amount of unsafe and use new imports #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
force-pushed
the
reduce_unsafe
branch
2 times, most recently
from
8ce2fc8
to
1902274
Compare
aewag
reviewed
Jan 26, 2022
| strategy: | ||
| matrix: | ||
| rust: | ||
| - ${{needs.set-msrv.outputs.msrv}} | ||
| - 1.51 # 1.41-1.50 `--features` can't be used inside virtual manifest |
There was a problem hiding this comment.
This was the reason why to change the directory and not to use the package option [1].
[1] 1902274#diff-7989ad9cb1e81934c64205efcfae23eb8bfc6aa827cc5c0f992a9704687a56e8L31
There was a problem hiding this comment.
Addition of this option was intentional. It is needed in cases when we prototype stuff using [patch.crates-io] in workspace's Cargo.toml, without it cross ignores it.
There was a problem hiding this comment.
Ah, makes sense 👍. I did not have this in mind.
newpavlov
force-pushed
the
reduce_unsafe
branch
from
10f5b73
to
86afa44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on RustCrypto/traits#849