Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.10.0 and 0.10.1 fails to compile #348

Closed
VersBinarii opened this issue Jan 7, 2022 · 3 comments
Closed

0.10.0 and 0.10.1 fails to compile #348

VersBinarii opened this issue Jan 7, 2022 · 3 comments

Comments

@VersBinarii
Copy link
Contributor

VersBinarii commented Jan 7, 2022

Hello,

Those two versions of blake2 hash fail to compile with following error:

error[E0310]: the parameter type `OutSize` may not live long enough
   --> /home/kris/Devel/hashes/blake2/src/macros.rs:364:13
    |
364 |             type OutputSize = OutSize;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
   ::: /home/kris/Devel/hashes/blake2/src/lib.rs:143:1
    |
143 | blake2_mac_impl!(Blake2bMac, Blake2bVarCore, U64, "Blake2b MAC function");

I created a pull request #347 to add those bounds in

@newpavlov
Copy link
Member

Weird... I can not reproduce it. What compiler version are you using? Have you tried cargo update?

@VersBinarii
Copy link
Contributor Author

I'm using:

➜ rustc --version
rustc 1.57.0 (f1edd0429 2021-11-29)

And just to clarify it, i see this error when compiling my app that is using the blake crate not when compiling the blake crate directly.
Hope that makes sense as i was confused by this as well.

@newpavlov
Copy link
Member

I was unable to reproduce it in a separate app as well. I guess, I will simply merge your PR for now, since it should not have any negative impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants