Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, that escalated quickly... Sorry for any noise!
This PR adds cross-tests to
sha3
crate. It does so by using the composite action namedcross-tests
, which can be found in.github/actions/cross-tests/action.yml
Inputs to the
cross-tests
actions are: Rust Version, Package, Target & FeaturesI adapted the
sha1
&sha2
crate to use the same composite action to reduce duplicated code (other crates seemed not to use any cross-tests).Further I changed the place where
MSRV
is defined. It now can be set in theenv
section in the beginning of the.yml
file at a single place.Disadvantage: It needs one job run before anything else to distribute it. But that could also be used in the future to create the Strategy Matrix at a single place and distribute it to the jobs.
Issue came up in #338