sha1: add multiplatform tests #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
sha1/multiplatform-tests
branch
from
7ad270d
to
32dcfd7
Compare
Expands the test suite to be similar to the one used by the `sha2` crate which tests the following platforms: - Linux: i686/x86_64/aarch64 (latter w\ cross) - Windows: x86_64 - macOS: x86_64 Additionally tests the `asm` feature on all Linux platforms as well as on macOS. Tests on i686 and cross-based tests for aarch64 are currently disabled because the `asm` feature is failing. See RustCrypto/hashes#251
tarcieri
force-pushed
the
sha1/multiplatform-tests
branch
from
32dcfd7
to
0be03e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the test suite to be similar to the one used by the
sha2crate which tests the following platforms:Additionally tests the
asmfeature on all Linux platforms as well as on macOS.Note: per #251, it's likelyEdit: it did, so I commented out the relevant parts so the tests pass but someone who wants to work on #251 can uncomment them to check fixes in CI.asmwill fail on Linux/aarch64