Expose sha256_utils behind a feature flag. #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Mar 24, 2020
|
In general this PR has a lot of seemingly unrelated formatting changes which, while good on their own, make it a bit hard to review. |
|
An alternative suggestion for accomplishing your intended goals here: How about an off-by-default |
|
Awesome, looks great! |
tarcieri
approved these changes
Mar 24, 2020
|
Thank you very much! 🎉 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use
compress256as part of Zcash Sprout key derivation; this change exposes it as part of thesha256_utilsmodule when using theutilsfeature.