Allow compile-time detection of crypto extension on AArch64 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing way depends on the libc crate, only works on Linux, and does a getauxval() call each 64 bytes of input. This commit adds support for doing this detection at compile-time, if the target_feature crypto is enabled we can use the same code-path as amd64 and reuse the asm feature. A new compile_error!() has been added helping users figure out the best way to build this crate.
linkmauve
force-pushed
the
compile-time-aarch64-crypto
branch
3 times, most recently
from
9ba4c10
to
3f9b926
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing way depends on the
libccrate, only works on Linux, and does agetauxval()call each 64 bytes of input.This commit adds support for doing this detection at compile-time, if the
"crypto"target_featureis enabled we can use the same code-path as amd64 and reuse theasmfeature. It should also work on non-Linuxtarget_os, but this is untested.A new
compile_error!()has been added helping users figure out the best way to build this crate.Benchmarks don’t seem to change much without the
getauxval()call, they’re all within error range.