der: refactor Int*/Uint* types
#881
Merged
+673
−666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factors these types out of the (now-removed) `bigint` module into the `int` and `uint` modules respectively, avoiding other code changes and preserving all tests.
tarcieri
added a commit
that referenced
this pull request
Feb 26, 2023
Now that code has been factored into the appropriate modules in #881 the visibility of various integer decoding/encoding functions can be much more restricted. This removes `pub(super)` where it's now unnecessary.
tarcieri
added a commit
that referenced
this pull request
Feb 26, 2023
Now that code has been factored into the appropriate modules in #881 the visibility of various integer decoding/encoding functions can be much more restricted. This removes `pub(super)` where it's now unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factors these types out of the (now-removed)
bigintmodule into theintanduintmodules respectively, avoiding other code changes and preserving all tests.