Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(deps) p521 crate requires ecdsa 16.8 #1038

Open
joshka opened this issue Mar 31, 2024 · 2 comments
Open

Bug(deps) p521 crate requires ecdsa 16.8 #1038

joshka opened this issue Mar 31, 2024 · 2 comments

Comments

@joshka
Copy link

joshka commented Mar 31, 2024

Hey, doing a minimal versions check on another library, I stumbled on p521 not being able to compile against the stated dependencies.

p521 0.13.3 requires ecdsa 0.16.8 , but specifies 0.16.5

Error Details

error[E0432]: unresolved import `ecdsa_core::hazmat::sign_prehashed`
  --> /Users/joshka/.cargo/registry/src/index.crates.io-6f17d22bba15001f/p521-0.13.3/src/ecdsa.rs:48:30
   |
48 |         hazmat::{bits2field, sign_prehashed, SignPrimitive, VerifyPrimitive},
   |                              ^^^^^^^^^^^^^^ no `sign_prehashed` in `hazmat`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `p521` (lib) due to 1 previous error

Change that introduces the sign_prehashed function
RustCrypto/signatures@d7557a6

@tarcieri
Copy link
Member

Aah, we normally run a minimal-versions check but it seems this was missed for p521.

A fix would require a backport since master currently has the next prerelease versions, but I can get to it at some point.

@joshka
Copy link
Author

joshka commented Mar 31, 2024

I figured that might be the case seeing the -pre dep in the Cargo.toml. I wasn't sure quite what your release process would be for something like that.

The workaround for any consuming packages in the mean time (assuming they care about such things) is to just add ecdsa 0.16.8 as a dependency, so it's not a huge deal.

Aah, we normally run a minimal-versions check but it seems this was missed for p521.

Sounds like this might be worth adding to your CI.

joshka added a commit to joshka/elliptic-curves that referenced this issue Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants