Fix and test minimal versions build #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
changed the title
newpavlov
force-pushed
the
fix_min_versions
branch
from
18cafa0
to
8f83e1f
Compare
tarcieri
reviewed
Feb 16, 2022
.github/workflows/aes.yml
Outdated
Comment on lines
59
to
72
| minimal-versions: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - uses: actions-rs/toolchain@v1 | ||
| with: | ||
| toolchain: nightly | ||
| override: true | ||
| profile: minimal | ||
| - run: rm ../Cargo.toml | ||
| - run: rm ../Cargo.lock | ||
| - run: cargo update -Z minimal-versions | ||
| - run: cargo test --release | ||
| - run: cargo test --release --all-features |
There was a problem hiding this comment.
This seems like something it'd be good to extract as a shared workflow ala https://github.com/RustCrypto/actions/blob/master/.github/workflows/set-msrv.yml
There was a problem hiding this comment.
My first attempt in RustCrypto/actions#3 has failed, so I think it's worth to leave it for a later PR.
newpavlov
force-pushed
the
fix_min_versions
branch
from
209dbc3
to
d3d51a8
Compare
newpavlov
force-pushed
the
fix_min_versions
branch
from
d3d51a8
to
4250bed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.