Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename crypto target feature to aes #279

Merged
merged 3 commits into from Aug 26, 2021
Merged

Rename crypto target feature to aes #279

merged 3 commits into from Aug 26, 2021

Conversation

newpavlov
Copy link
Member

@newpavlov newpavlov commented Aug 26, 2021 •
edited

No description provided.

@newpavlov newpavlov mentioned this pull request Aug 26, 2021
Merged
@newpavlov
Copy link
Member Author

Ah, cpufeatures already enables aes, so no changes are needed there.

@tarcieri
Do you think we should remove crypto from it eventually?

@tarcieri
Copy link
Member

@newpavlov probably. I was trying to map 1:1 with the Rust features, so if those changed so should cpufeatures.

Perhaps it's time for a v0.2 release.

@newpavlov newpavlov merged commit 0353e66 into master Aug 26, 2021
@newpavlov newpavlov deleted the aes_armv8 branch August 26, 2021 13:54
@tarcieri tarcieri mentioned this pull request Aug 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@newpavlov @tarcieri