Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aes: bump ctr dependency to v0.8 #275

Merged
merged 2 commits into from Jul 9, 2021
Merged

aes: bump ctr dependency to v0.8 #275

merged 2 commits into from Jul 9, 2021

Conversation

newpavlov
Copy link
Member

No description provided.

@newpavlov newpavlov changed the title aes: update to ctr v0.8 aes: bump ctr dependency to v0.8 Jul 9, 2021
Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to cut a breaking release, there are a few other changes I'd like to get in (mostly cleaning up the hazmat module which kind of grew organically alongside the deoxys crate)

@newpavlov
Copy link
Member Author

newpavlov commented Jul 9, 2021

Nah, I don't plan doing an aes release in the near future (this is why I've used "unreleased" in the changelog). Also I don't think this change warrants a breaking release. ctr v0.8 was released only because of the breaking changes in the flavor trait. The Ctr type got more general, so it should be backwards compatible API-wise. aes exposes only already instantiated CTR types. Interface for those is defined via traits from the same cipher v0.3 (there are also 2 inherent methods, but they are left unchanged from ctr v0.7). Thus, I think it's fine to do a patch release here.

@newpavlov newpavlov merged commit c282099 into master Jul 9, 2021
@newpavlov newpavlov deleted the ctr_update branch July 9, 2021 03:54
@tarcieri tarcieri mentioned this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants