Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaddingScheme being !Send makes things harder #214

Closed
gdesmott opened this issue Oct 20, 2022 · 2 comments · Fixed by #215
Closed

PaddingScheme being !Send makes things harder #214

gdesmott opened this issue Oct 20, 2022 · 2 comments · Fixed by #215

Comments

@gdesmott
Copy link
Contributor

See librespot-org/librespot#1065

PaddingScheme is !Send making it impossible to use it in async code requiring Send futures.

Is there any way this could be prevented?
@gdesmott gdesmott mentioned this issue Oct 20, 2022
Closed
@tarcieri
Copy link
Member

It's probably because the Box<DynDigest> members aren't Box<DynDigest + Send>.

@gdesmott alternatively you could use e.g. rsa::pkcs1v15::{SigningKey, VerifyingKey} or rsa::pss::{SigningKey, VerifyingKey} which are Send (+ Sync) maybe?

gdesmott added a commit to gdesmott/RSA that referenced this issue Oct 20, 2022
@gdesmott
padding: ensure PaddingScheme is Send
c764f8a 
It's more convenient for users.

Fix RustCrypto#214
@gdesmott gdesmott mentioned this issue Oct 20, 2022
Merged
@gdesmott
Copy link
Contributor Author

It's probably because the Box<DynDigest> members aren't Box<DynDigest + Send>.

Indeed, and it's quite easy to fix: #215

gdesmott added a commit to gdesmott/RSA that referenced this issue Oct 20, 2022
@gdesmott
padding: ensure PaddingScheme is Send and Sync
8f07f84 
It's more convenient for users.

Fix RustCrypto#214
tarcieri pushed a commit that referenced this issue Oct 24, 2022
@gdesmott
padding: ensure PaddingScheme is Send and Sync (#215)
a857c8f 
It's more convenient for users.

Fix #214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

padding: ensure PaddingScheme is Send and Sync gdesmott/RSA
2 participants
@tarcieri @gdesmott